Skip to content

fix: add pytorch 1.8.1 for huggingface #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 23, 2021
Merged

fix: add pytorch 1.8.1 for huggingface #2642

merged 19 commits into from
Sep 23, 2021

Conversation

jeniyat
Copy link
Contributor

@jeniyat jeniyat commented Sep 15, 2021 •
edited
Loading

fix HF cuda version for PR #2570
Description of changes:

Testing done:
Unit tests.

Description of changes:

  • Added cuda 111 support for HF:: modified files: ./src/sagemaker/image_uris.py
  • Fixed issues with HF_latest_version:: modified files: ./tests/conftest.py

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ahsan-z-khan ahsan-z-khan changed the title fix: add pytorch 1.8.1 for huggingface #2639 fix: add pytorch 1.8.1 for huggingface Sep 15, 2021
@jeniyat jeniyat mentioned this pull request Sep 15, 2021
Closed
7 tasks
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bca9414
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: a81cfbf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e95e0ce
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6c134b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 31c20ab
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan ahsan-z-khan mentioned this pull request Sep 20, 2021
Closed
7 tasks
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 015888c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 90097d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 613fa6a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala
mufaddal-rohawala reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@mufaddal-rohawala mufaddal-rohawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jeniya, There is an empty file .coverage.a0..... Can we delete that?

navinsoni
navinsoni reviewed Sep 21, 2021
View reviewed changes
@navinsoni
Copy link
Contributor

Hey Jeniya, There is an empty file .coverage.a0..... Can we delete that?

+1

mufaddal-rohawala
mufaddal-rohawala previously approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@mufaddal-rohawala mufaddal-rohawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do await for tests to complete before merge.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 28f5ac1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

1 similar comment
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 28f5ac1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 86b70be
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 40db98e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 89c1145
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jeniyat jeniyat merged commit f7a57c2 into aws:master Sep 23, 2021
@jeniyat jeniyat deleted the huggingface_cu111 branch September 23, 2021 15:43
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Sep 24, 2021
@jeniyat @ahsan-z-khan
@shreyapandit @jerrypeng7773
fix: add pytorch 1.8.1 for huggingface (aws#2642)
5e9fdba 
* added pytorch 1.8.1 for supporting huggingface

* fix: add pytorch 1.8.1 for huggingface

* fix: add pytorch 1.8.1 for huggingface

* refactored code for flake

* refactored code for docstyle

* fix: add alias for pytorch 1.8

* update to master

* add version alias for pytorch1.8 in huggingface.json

* add version alias for pytorch1.8 in huggingface.json

* removed empty file, corrected grammar

* removed empty line in test_estimator

* removed empty line in test_estimator

* removed empty line in test_estimator

Co-authored-by: Tabassum <[email protected]>
Co-authored-by: Ahsan Khan <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
@jeniyat @ahsan-z-khan
@shreyapandit @EthanShouhanCheng
fix: add pytorch 1.8.1 for huggingface (aws#2642)
3bb893f 
* added pytorch 1.8.1 for supporting huggingface

* fix: add pytorch 1.8.1 for huggingface

* fix: add pytorch 1.8.1 for huggingface

* refactored code for flake

* refactored code for docstyle

* fix: add alias for pytorch 1.8

* update to master

* add version alias for pytorch1.8 in huggingface.json

* add version alias for pytorch1.8 in huggingface.json

* removed empty file, corrected grammar

* removed empty line in test_estimator

* removed empty line in test_estimator

* removed empty line in test_estimator

Co-authored-by: Tabassum <[email protected]>
Co-authored-by: Ahsan Khan <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyapandit shreyapandit shreyapandit left review comments

@navinsoni navinsoni navinsoni left review comments

@ahsan-z-khan ahsan-z-khan ahsan-z-khan approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeniyat @sagemaker-bot @navinsoni @shreyapandit @ahsan-z-khan @mufaddal-rohawala