-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: add pytorch 1.8.1 for huggingface #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
||
from sagemaker import utils | ||
from sagemaker.spark import defaults | ||
from sagemaker.spark import defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got added twice?
@@ -17,9 +17,12 @@ | |||
import logging | |||
import os | |||
import re | |||
import pdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed.
@@ -90,12 +105,16 @@ def retrieve( | |||
processor = _processor( | |||
instance_type, config.get("processors") or version_config.get("processors") | |||
) | |||
#if container version is available in .json file, utilize that | |||
if "container_version" in version_config.keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use if version_config.get("container_version"):
?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
closing with a new PR: #2642 |
Issue #, if available:
fix HF cuda version for PR #2570
Description of changes:
Testing done:
Unit tests.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.