Skip to content

feature: update HF imageUris for PyTorch 1.8.1 #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

feature: update HF imageUris for PyTorch 1.8.1 #2570

wants to merge 8 commits into from

Conversation

ahsan-z-khan
Copy link
Member

@ahsan-z-khan ahsan-z-khan commented Aug 10, 2021 •
edited
Loading

Issue #, if available:

Description of changes:
Update ImageUri to include PyTorch 1.8 images to HF
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ahsan-z-khan ahsan-z-khan changed the title feature: update HF image for PyTorch 1.8 feature: update HF image for PyTorch 1.8.1 Aug 10, 2021
@ahsan-z-khan ahsan-z-khan changed the title feature: update HF image for PyTorch 1.8.1 feature: update HF imageUris for PyTorch 1.8.1 Aug 10, 2021
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ce81939
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

saimidu
saimidu reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@saimidu saimidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just adding the ap-northeast-3 region to the training image region list would make this PR good to go.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ce81939
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ce81939
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ce81939
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ce81939
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan ahsan-z-khan mentioned this pull request Aug 10, 2021
Closed
@ahsan-z-khan ahsan-z-khan added the status: pending release The fix have been merged but not yet released to PyPI label Aug 10, 2021
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 66853ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 66853ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 66853ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 66853ea
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 66853ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

philschmid
philschmid approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for adding already inference to it.

@Roshrini
Copy link

@arjkesh I see HF images are out https://github.com/aws/deep-learning-containers/releases/tag/v1.0-hf-4.6.1-pt-1.8.1-py36
Is this PR good to get merged?

@arjkesh
Copy link
Contributor

arjkesh commented Aug 26, 2021

Hi @Roshrini - yes, the release is out. The owner of this PR is @ahsan-z-khan - it looks like there is a test failing. @ahsan-z-khan could you provide an update for @Roshrini?

@ahsan-z-khan
Copy link
Member Author

Hi @Roshrini - yes, the release is out. The owner of this PR is @ahsan-z-khan - it looks like there is a test failing. @ahsan-z-khan could you provide an update for @Roshrini?

The failure seems to be related.

Failed. Reason: ClientError: API error (404): manifest for 763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-training:1.8.1-transformers4.6.1-gpu-py36-cu110-ubuntu18.04 not found: manifest unknown: Requested image not found

I think it's related cu110. It should be be cu111

@arjkesh
Copy link
Contributor

arjkesh commented Aug 26, 2021

Hi @Roshrini - yes, the release is out. The owner of this PR is @ahsan-z-khan - it looks like there is a test failing. @ahsan-z-khan could you provide an update for @Roshrini?

The failure seems to be related.

Failed. Reason: ClientError: API error (404): manifest for 763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-training:1.8.1-transformers4.6.1-gpu-py36-cu110-ubuntu18.04 not found: manifest unknown: Requested image not found

I think it's related cu110. It should be be cu111

Thanks for the heads up. Yes, the HF DLC is cu111, just like the regular PT1.8 DLC. Bumping this link for reference - https://github.com/aws/deep-learning-containers/releases/tag/v1.0-hf-4.6.1-pt-1.8.1-py36

This was referenced Sep 14, 2021
Closed
Merged
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b67e68c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@philschmid
Copy link
Contributor

Hey @ahsan-z-khan ,
We are currently releasing new Images. You can take a look here:aws/deep-learning-containers#1326 (comment)
Maybe can add the config in this PR here as well and the merge after the new PyTorch Container are available

@ahsan-z-khan
Copy link
Member Author

@philschmid , Are those update for 4.10 transformer?

@philschmid
Copy link
Contributor

@philschmid , Are those update for 4.10 transformer?

Yes ! new Container for Pytorch 1.8. for inference and training with Transformers 4.10 same for Tensorflow 2.4

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 436b49b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@philschmid
Copy link
Contributor

Images are released when can we get this out?

@ahsan-z-khan
Copy link
Member Author

Images are released when can we get this out?

@philschmid , this is dependent on #2642

We are updating the SDK to support cuda111 and later.

@philschmid
Copy link
Contributor

any ETA on this?

@philschmid
Copy link
Contributor

FYI we also merged new Images for PyTorch 1.9 and TF2.5
aws/deep-learning-containers#1354
This need to be added soon as well

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f1a613d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan
Copy link
Member Author

@philschmid , trying to merge today.

@ahsan-z-khan
Copy link
Member Author

closing in regards of #2642

@ahsan-z-khan ahsan-z-khan deleted the update_HF_image branch December 17, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimidu saimidu saimidu left review comments

@shreyapandit shreyapandit shreyapandit approved these changes

@philschmid philschmid philschmid approved these changes

@arjkesh arjkesh arjkesh approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

Assignees
No one assigned
Labels
status: pending release The fix have been merged but not yet released to PyPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ahsan-z-khan @sagemaker-bot @Roshrini @arjkesh @philschmid @shreyapandit @saimidu @mufaddal-rohawala @navinsoni