Skip to content

fix: propagate KMS key to model.deploy #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2021
Merged

fix: propagate KMS key to model.deploy #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a414ea
Propagate KMS key to model.deploy
shreyapandit Aug 27, 2021
99850a5
Update more methods on AutoML test
shreyapandit Aug 27, 2021
1737f9a
update attribute param to be correct
shreyapandit Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sagemaker/automl/automl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ def deploy(
serializer=serializer,
deserializer=deserializer,
endpoint_name=endpoint_name,
kms_key=model_kms_key,
tags=tags,
wait=wait,
)
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/sagemaker/automl/test_auto_ml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ def test_deploy(sagemaker_session, candidate_mock):
initial_instance_count=INSTANCE_COUNT,
instance_type=INSTANCE_TYPE,
sagemaker_session=sagemaker_session,
model_kms_key=OUTPUT_KMS_KEY,
)
auto_ml.create_model.assert_called_once()
mock_pipeline.deploy.assert_called_once()
Expand Down Expand Up @@ -594,6 +595,7 @@ def test_deploy_optional_args(candidate_estimator, sagemaker_session, candidate_
serializer=None,
deserializer=None,
endpoint_name=JOB_NAME,
kms_key=OUTPUT_KMS_KEY,
tags=TAGS,
wait=False,
)
Expand Down