Skip to content

fix: propagate KMS key to model.deploy #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2021
Merged

fix: propagate KMS key to model.deploy #2603

merged 3 commits into from
Aug 27, 2021

Conversation

shreyapandit
Copy link
Contributor

@shreyapandit shreyapandit commented Aug 27, 2021

Issue #, if available:
https://tiny.amazon.com/1icjcjclz

Description of changes:

In AUTOML functionality, propagate KMS Key to the model's deploy step and fix units

Testing done: Ran all unit tests


TOTAL 14759 1618 89%

5001 passed, 447 skipped, 1 xfailed, 1 xpassed, 3046 warnings in 323.62s (0:05:23)

Ran tox -e flake8,pylint,docstyle,black-check,twine --parallel successfully
✔ OK black-check in 12.013 seconds
✔ OK twine in 13.856 seconds
✔ OK pylint in 26.937 seconds
✔ OK docstyle in 28.902 seconds
✔ OK flake8 in 47.925 seconds

TOTAL 14759 1618 89%

==================== 5001 passed, 447 skipped, 1 xfailed, 1 xpassed, 3046 warnings in 323.62s (0:05:23) =====================

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shreyapandit shreyapandit changed the title Propagate KMS key to model.deploy fix: propagate KMS key to model.deploy Aug 27, 2021
@aws aws deleted a comment from sagemaker-bot Aug 27, 2021
@aws aws deleted a comment from sagemaker-bot Aug 27, 2021
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1737f9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan ahsan-z-khan merged commit da77745 into aws:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants