Skip to content

Remove unused arg job_detail for EstimatorBase.attach() #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2018
Merged

Remove unused arg job_detail for EstimatorBase.attach() #210

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4abc36
Remove unused argument job_detail for attach()
yangaws Jun 1, 2018
7b835a6
Update changelog
yangaws Jun 1, 2018
76b0990
Merge branch 'master' into rm_job_detail
yangaws Jun 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG
========

* bug-fix: Estimators: Change max_iterations hyperparameter key for KMeans
* bug-fix: Estimators: Remove unused argument job_details for ``EstimatorBase.attach()``

1.3.0
=====
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def _from_training_job(cls, init_params, hyperparameters, image, sagemaker_sessi
raise NotImplementedError()

@classmethod
def attach(cls, training_job_name, sagemaker_session=None, job_details=None):
def attach(cls, training_job_name, sagemaker_session=None):
"""Attach to an existing training job.

Create an Estimator bound to an existing training job, each subclass is responsible to implement
Expand Down