Skip to content

Remove unused arg job_detail for EstimatorBase.attach() #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Jun 1, 2018

Issue #, if available:
job detail is always fetched by sagemaker_session. So passing it as an argument to EstimatorBase.attach() does not make sense.

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested review from owen-t and iquintero June 1, 2018 20:57
@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #210 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #210     +/-   ##
=========================================
- Coverage      91%   90.71%   -0.3%     
=========================================
  Files          42       42             
  Lines        2714     2714             
=========================================
- Hits         2470     2462      -8     
- Misses        244      252      +8
Impacted Files Coverage Δ
src/sagemaker/estimator.py 86.1% <100%> (ø) ⬆️
src/sagemaker/local/image.py 85.44% <0%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf7e12...76b0990. Read the comment docs.

@yangaws yangaws merged commit 7f13df0 into aws:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants