-
Notifications
You must be signed in to change notification settings - Fork 1.2k
breaking: Move _JsonSerializer to sagemaker.serializers.JSONSerializer #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - one optional comment, but you can ignore it.
def test_json_serializer_numpy_valid(json_serializer): | ||
result = json_serializer.serialize(np.array([1, 2, 3])) | ||
|
||
assert result == "[1, 2, 3]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I didn't really notice this before because I know you're just copying the tests over, but I believe the expected result is actually supposed to go first in the comparison. (The order is for the error message when the assertion fails.)
Issue #, if available: #1694
Description of changes:
Moved
sagemaker.serializers._JsonSerializer
tosagemaker.serializers.JSONSerializer
Testing done:
Moved related tests from
tests.unit.test_predicctor
totests.unit.sagemaker.test_serializers
.Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.