Skip to content

Move SerDe to dedicated modules #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bveeramani opened this issue Jul 9, 2020 · 0 comments
Closed

Move SerDe to dedicated modules #1694

bveeramani opened this issue Jul 9, 2020 · 0 comments
Assignees
@bveeramani
Labels
type: feature request
Milestone
v2.0.0

Comments

@bveeramani
Copy link
Contributor

bveeramani commented Jul 9, 2020 •
edited
Loading

To improve discoverability, we should move and rename the following objects:

Before After PR
sagemaker.predictor._CsvDeserializer sagemaker.deserializers.CSVDeserializer #1682
sagemaker.predictor._CsvSerializer sagemaker.serializers.CSVSerializer #1700
sagemaker.predictor.BytesDeserializer sagemaker.deserializers.BytesDeserializers #1674
sagemaker.predictor.StringDeserializer sagemaker.deserializers.StringDeserializer #1677
sagemaker.predictor.StreamDeserializer sagemaker.deserializers.StreamDeserializer #1679
sagemaker.predictor._JsonSerializer sagemaker.serializers.JSONSerializer #1698
sagemaker.predictor._NumpyDeserializer sagemaker.deserializers.NumpyDeserializer #1695
sagemaker.predictor._NPYSerializer sagemaker.serializers.NumpySerializer #1691
sagemaker.amazon.common.numpy_to_record_serializer sagemaker.amazon.serializers.RecordSerializer #1690
sagemaker.amazon.common.record_deserializer sagemaker.amazon.deserializers.RecordDeserializer #1683
sagemaker.predictor._JsonDeserializer sagemaker.deserializers.JSONDeserializer #1697
@bveeramani bveeramani self-assigned this Jul 9, 2020
This was referenced Jul 9, 2020
Merged
Merged
Merged
Merged
@laurenyu laurenyu mentioned this issue Jul 10, 2020
Closed
@bveeramani bveeramani mentioned this issue Jul 10, 2020
Merged
7 tasks
@laurenyu laurenyu added this to the v2.0.0 milestone Jul 10, 2020
@bveeramani bveeramani mentioned this issue Jul 22, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bveeramani bveeramani

Labels
type: feature request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@laurenyu @bveeramani