Skip to content

trivial change to trigger a new build #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

trivial change to trigger a new build #1532

wants to merge 1 commit into from

Conversation

ajaykarpur
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajaykarpur ajaykarpur closed this May 29, 2020
@ajaykarpur ajaykarpur deleted the build-system-test branch May 29, 2020 00:46
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Feature: Add unit tests for recipes and minor bug fixes. (#1532)
e68f4f5 
* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Update URIs to public for training recipes (#1621)
74d6b7c 
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Neuron URIs update (#1626)
fdf2e9a 
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Usage docs for training recipes (#1630)
3bce287 
* Feature: Support GPU training recipes with Sagemaker Python SDK (#1516)

* v0 estimator for launching kandinksy training

* code cleanup

* option to over-ride git repos for kandinsky for testing purposes

* update dependencies

* update comment

* formatting fixes

* style fixes

* code cleanup

* Add warning messages for ingored arguments

* cleanup, address comments

* fix

* clone launcher repo only if necessary

* add a cleanup method to call after fit

* fix docstring

* fix warning

* cleanup update

* fix

* code style fix

* rename cleanup method for clarity

* missed change

* move cleanup to when object is destroyed

* add unit tests

* formatting fix

* removing tests which don't work as recipe repos are private

* removing tests which don't work as recipe repos are private

* resolve comments

* resolve comments

* Feature: Support Neuron training recipes. (#1526)

* Feature: Resolve recipes correctly before launching (#1529)

* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering

* Feature: Add unit tests for recipes and minor bug fixes. (#1532)

* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes

* Feature: Move image uris and git repos for training recipes to json (#1547)

* Update MANIFEST.in so that wheel builds correctly (#1563)

* Remove default values for fields in recipe_overrides and fix recipe path. (#1566)

* add optional source dir for recipes, copy training code and requirements to source dir

* diff names for recipe file and local script option

* format and add unit test

* make entry point script and recipe file temp files that can be gced

* formatting and fix

* test fix

* test fixes

* format fix

* break function up because it is too long

* fixes

* fix

* fix

* remove references to launcher and adapter dir as we copy out everything needed into source dir

* reformat

* copy all directory contents for trainium as there is more than one source file

* fix

* fix

* remove debugging message

* Change default source directory to current, add option to specify source dir (#1593)

* update to public uris for hyperpod recipe repos and smp image

* fixes

* remove debug copies

* change caps for env vars

* skip some tests for now

* format

* neuron json for retrieving images

* update training_recipes.json

* add unit test

* reformat

* fix long line

* add source dir check when using training recipe

* adding more regions

* reformat

* doc update

* doc update

* doc update

* doc update

* fix capitalization issues

* fix capitalization issues

* doc check issue
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Feature: Add unit tests for recipes and minor bug fixes. (#1532)
e195b0b 
* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Update URIs to public for training recipes (#1621)
a8a812b 
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Neuron URIs update (#1626)
36a8f0f 
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@schinmayee @pintaoz-aws
Usage docs for training recipes (#1630)
efc9aa8 
* Feature: Support GPU training recipes with Sagemaker Python SDK (#1516)

* v0 estimator for launching kandinksy training

* code cleanup

* option to over-ride git repos for kandinsky for testing purposes

* update dependencies

* update comment

* formatting fixes

* style fixes

* code cleanup

* Add warning messages for ingored arguments

* cleanup, address comments

* fix

* clone launcher repo only if necessary

* add a cleanup method to call after fit

* fix docstring

* fix warning

* cleanup update

* fix

* code style fix

* rename cleanup method for clarity

* missed change

* move cleanup to when object is destroyed

* add unit tests

* formatting fix

* removing tests which don't work as recipe repos are private

* removing tests which don't work as recipe repos are private

* resolve comments

* resolve comments

* Feature: Support Neuron training recipes. (#1526)

* Feature: Resolve recipes correctly before launching (#1529)

* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering

* Feature: Add unit tests for recipes and minor bug fixes. (#1532)

* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes

* Feature: Move image uris and git repos for training recipes to json (#1547)

* Update MANIFEST.in so that wheel builds correctly (#1563)

* Remove default values for fields in recipe_overrides and fix recipe path. (#1566)

* add optional source dir for recipes, copy training code and requirements to source dir

* diff names for recipe file and local script option

* format and add unit test

* make entry point script and recipe file temp files that can be gced

* formatting and fix

* test fix

* test fixes

* format fix

* break function up because it is too long

* fixes

* fix

* fix

* remove references to launcher and adapter dir as we copy out everything needed into source dir

* reformat

* copy all directory contents for trainium as there is more than one source file

* fix

* fix

* remove debugging message

* Change default source directory to current, add option to specify source dir (#1593)

* update to public uris for hyperpod recipe repos and smp image

* fixes

* remove debug copies

* change caps for env vars

* skip some tests for now

* format

* neuron json for retrieving images

* update training_recipes.json

* add unit test

* reformat

* fix long line

* add source dir check when using training recipe

* adding more regions

* reformat

* doc update

* doc update

* doc update

* doc update

* fix capitalization issues

* fix capitalization issues

* doc check issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajaykarpur