Skip to content

documentation: fix undoc directive; removes extra tabs #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented May 27, 2020

Docs build was failing on some extra tabs.

Merge Checklist

General

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaronmarkham aaronmarkham requested a review from laurenyu May 27, 2020 18:26
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 4f1272b into aws:master May 27, 2020
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* Feature: Support GPU training recipes with Sagemaker Python SDK (#1516)

* v0 estimator for launching kandinksy training

* code cleanup

* option to over-ride git repos for kandinsky for testing purposes

* update dependencies

* update comment

* formatting fixes

* style fixes

* code cleanup

* Add warning messages for ingored arguments

* cleanup, address comments

* fix

* clone launcher repo only if necessary

* add a cleanup method to call after fit

* fix docstring

* fix warning

* cleanup update

* fix

* code style fix

* rename cleanup method for clarity

* missed change

* move cleanup to when object is destroyed

* add unit tests

* formatting fix

* removing tests which don't work as recipe repos are private

* removing tests which don't work as recipe repos are private

* resolve comments

* resolve comments

* Feature: Support Neuron training recipes. (#1526)

* Feature: Resolve recipes correctly before launching (#1529)

* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering

* Feature: Add unit tests for recipes and minor bug fixes. (#1532)

* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes

* Feature: Move image uris and git repos for training recipes to json (#1547)

* Update MANIFEST.in so that wheel builds correctly (#1563)

* Remove default values for fields in recipe_overrides and fix recipe path. (#1566)

* add optional source dir for recipes, copy training code and requirements to source dir

* diff names for recipe file and local script option

* format and add unit test

* make entry point script and recipe file temp files that can be gced

* formatting and fix

* test fix

* test fixes

* format fix

* break function up because it is too long

* fixes

* fix

* fix

* remove references to launcher and adapter dir as we copy out everything needed into source dir

* reformat

* copy all directory contents for trainium as there is more than one source file

* fix

* fix

* remove debugging message

* Change default source directory to current, add option to specify source dir (#1593)

* update to public uris for hyperpod recipe repos and smp image

* fixes

* remove debug copies

* change caps for env vars

* skip some tests for now

* format

* neuron json for retrieving images

* update training_recipes.json

* add unit test

* reformat

* fix long line

* add source dir check when using training recipe

* adding more regions

* reformat

* doc update

* doc update

* doc update

* doc update

* fix capitalization issues

* fix capitalization issues

* doc check issue
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
Resolve recipes correctly before launching (#1529)
fixes. (#1532)
fix recipe path. (#1566)
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* Feature: Support GPU training recipes with Sagemaker Python SDK (#1516)

* v0 estimator for launching kandinksy training

* code cleanup

* option to over-ride git repos for kandinsky for testing purposes

* update dependencies

* update comment

* formatting fixes

* style fixes

* code cleanup

* Add warning messages for ingored arguments

* cleanup, address comments

* fix

* clone launcher repo only if necessary

* add a cleanup method to call after fit

* fix docstring

* fix warning

* cleanup update

* fix

* code style fix

* rename cleanup method for clarity

* missed change

* move cleanup to when object is destroyed

* add unit tests

* formatting fix

* removing tests which don't work as recipe repos are private

* removing tests which don't work as recipe repos are private

* resolve comments

* resolve comments

* Feature: Support Neuron training recipes. (#1526)

* Feature: Resolve recipes correctly before launching (#1529)

* fix to work with launcher recipes

* fix suffix for temp file

* fix path and error message

* fix for recipes from launcher

* resolve recipes correctly

* fix imports

* reformat message to avoid code-doc test issue

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* code style fix

* doc formatting

* check if resolver exists before registering

* Feature: Add unit tests for recipes and minor bug fixes. (#1532)

* basic checks and unit test for recipes

* More testing for recipes. Move recipe overrides to top before accessing any recipe fields.

* check that we use customer provided image uri if it is set

* reformat

* test fixes

* update git urls for recipes

* revert to ssh git urls for recipes

* Feature: Move image uris and git repos for training recipes to json (#1547)

* Update MANIFEST.in so that wheel builds correctly (#1563)

* Remove default values for fields in recipe_overrides and fix recipe path. (#1566)

* add optional source dir for recipes, copy training code and requirements to source dir

* diff names for recipe file and local script option

* format and add unit test

* make entry point script and recipe file temp files that can be gced

* formatting and fix

* test fix

* test fixes

* format fix

* break function up because it is too long

* fixes

* fix

* fix

* remove references to launcher and adapter dir as we copy out everything needed into source dir

* reformat

* copy all directory contents for trainium as there is more than one source file

* fix

* fix

* remove debugging message

* Change default source directory to current, add option to specify source dir (#1593)

* update to public uris for hyperpod recipe repos and smp image

* fixes

* remove debug copies

* change caps for env vars

* skip some tests for now

* format

* neuron json for retrieving images

* update training_recipes.json

* add unit test

* reformat

* fix long line

* add source dir check when using training recipe

* adding more regions

* reformat

* doc update

* doc update

* doc update

* doc update

* fix capitalization issues

* fix capitalization issues

* doc check issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants