-
Notifications
You must be signed in to change notification settings - Fork 1.2k
increase endpoint creation timeout to 20 minutes #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the message: so that it is in imperative mood 👍 |
I thought previously we had decided that a timeout of 15 minutes should be plenty. Did something change? |
@laurenyu it's a balance. we want to set the timeout so that tests that are going to fail anyway don't jam up the build queue, but we don't want to fail tests that will succeed because our timeouts are too low. i think @mvsusp has found that the current timeouts are causing too many artificial failures. |
Of course, I understand tradeoff. I just want to make sure we're not unnecessarily increasing the timeout - e.g. do all of the tests need to have increased timeouts? was 20 minutes based on running the tests without a timeout or just a small increase while we continue experimenting? I didn't see any explanation in this PR, so I wanted to ask if there was a previous conversation I had missed. |
@laurenyu I increased only the timeouts for endpoints creation. My (small) sample of experiments demonstrated that one of the possible issues with 15 minutes timeouts is when the endpoint delete operation happens while the endpoint creation operation is still happening. That results in a flaky error and an endpoint that was not deleted. Now that we have statistics in the integration tests, we can check which tests are slower and refactor them as necessary. |
cool, thanks for the explanation! |
aws#11 updated master to reflect the public SDK. This change brings this branch up to date.
FrameworkProcessor.get_run_args()
No description provided.