-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove upper bound on urllib in the local_requirements.txt
for CVE-2023-43804
#4168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
There is now also https://www.cve.org/CVERecord?id=CVE-2023-45803. Submitting PR. |
Docker python 6.1 now supports urllib 2+ so safe to go with the upper bound of 3. |
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Oct 19, 2023
…023-43804 and CVE-2023-45803 Docker python 6.1 now supports urllib 2+ https://github.com/docker/docker-py/releases/tag/6.1.0 Closes aws#4168
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Oct 19, 2023
Allows users to upgrade addressing CVE-2023-43804 and CVE-2023-45803 Docker python 6.1 now supports urllib 2+ https://github.com/docker/docker-py/releases/tag/6.1.0 closes aws#4168
8 tasks
jmahlik
added a commit
to StateFarmIns/sagemaker-python-sdk
that referenced
this issue
Oct 23, 2023
Allows users to upgrade addressing CVE-2023-43804 and CVE-2023-45803 Docker python 6.1 now supports urllib 2+ https://github.com/docker/docker-py/releases/tag/6.1.0 closes aws#4168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It's not possible to install higher versions of urllib3 to upgrade past the vulnerable version. Recommend removing the upper bound entirely since urllib3 2.0+ is out.
Unless removing entirely causes test failures. Then it could be upper bounded to
<2.0.0
. I'd be willing to work on updating dependencies to support urllib3 2.0+ if needed.https://www.cve.org/CVERecord?id=CVE-2023-43804
sagemaker-python-sdk/requirements/extras/local_requirements.txt
Line 1 in f631e41
To reproduce
Expected behavior
Installable.
Screenshots or logs
System information
A description of your system. Please provide:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: