fix(util-user-agent-node): should memoize app id

[AllanZhengYP]

Issue

Resolves: #2027

Description

This change fix an issue that SDK need to read shared config files to load App ID for every request. Now this change only load the App ID once at the client instantiation. This will remove some performance overhead.

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[TysonAndre]

Not a maintainer, but LGTM. nit - in case of future refactorings reintroducing similar bugs or sharing the same array object it might still be useful to assert the length is the expected value

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (main@0745502). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2223   +/-   ##
=======================================
  Coverage        ?   61.83%           
=======================================
  Files           ?      454           
  Lines           ?    23290           
  Branches        ?     5521           
=======================================
  Hits            ?    14402           
  Misses          ?     8888           
  Partials        ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0745502...db3f5c3. Read the comment docs.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• CodeBuild project: sdk-staging-test
• Commit ID: 8212881
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[TysonAndre]

Not a maintainer, but don't see any other issues

[AllanZhengYP]

Thanks @TysonAndre for looking into this PR. 👍

[matej-prokop]

Great! Thank you for fixing this. When do you plan to release? I would like to retry our perf test with this fix in place.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.