Skip to content

Commit db3f5c3

Browse files
fix(util-user-agent-node): address feedbacks
Co-authored-by: Tyson Andre <[email protected]>
1 parent 2aacebf commit db3f5c3

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

packages/util-user-agent-node/src/index.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,8 @@ describe("defaultUserAgent", () => {
5959
mockAppIdLoader.mockClear();
6060
const appId = "appId12345";
6161
mockAppIdLoader.mockResolvedValue(appId);
62-
const userAgnetProvider = defaultUserAgent({ serviceId: "s3", clientVersion: "0.1.0" });
63-
await userAgnetProvider();
64-
await userAgnetProvider();
62+
const userAgentProvider = defaultUserAgent({ serviceId: "s3", clientVersion: "0.1.0" });
63+
expect(await userAgentProvider()).toEqual(await userAgentProvider());
6564
expect(mockAppIdLoader).toBeCalledTimes(1);
6665
});
6766
});

packages/util-user-agent-node/src/index.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ export const defaultUserAgent = ({ serviceId, clientVersion }: DefaultUserAgentO
4343
default: undefined,
4444
})();
4545

46+
let resolvedUserAgent: UserAgent | undefined = undefined;
4647
return async () => {
47-
const appId = await appIdPromise;
48-
if (appId) {
49-
sections.push([`app/${appId}`]);
48+
if (!resolvedUserAgent) {
49+
resolvedUserAgent = [...sections, [`app/${await appIdPromise}`]];
5050
}
51-
return sections;
51+
return resolvedUserAgent;
5252
};
5353
};

0 commit comments

Comments
 (0)