Skip to content

feat: [old] add filterSensitiveLog for Union types #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 1, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#190

Description of changes:
adds filterSensitiveLog for Union types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #1314 into master will decrease coverage by 11.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1314       +/-   ##
===========================================
- Coverage   89.34%   77.49%   -11.86%     
===========================================
  Files         152      286      +134     
  Lines        3145    11899     +8754     
  Branches      579     2600     +2021     
===========================================
+ Hits         2810     9221     +6411     
- Misses        335     2678     +2343     
Impacted Files Coverage Δ
packages/url-parser-node/src/index.ts 72.72% <0.00%> (-27.28%) ⬇️
...-provider-cognito-identity/src/IndexedDbStorage.ts 6.52% <0.00%> (-12.23%) ⬇️
packages/signature-v4/src/moveHeadersToQuery.ts 84.61% <0.00%> (-6.30%) ⬇️
...-sdk-transcribe-streaming/src/websocket-handler.ts 77.77% <0.00%> (-1.91%) ⬇️
packages/hash-stream-node/src/hash-calculator.ts 88.88% <0.00%> (-1.12%) ⬇️
...eventstream-handler-node/src/EventSigningStream.ts 91.66% <0.00%> (-0.65%) ⬇️
...ckages/node-http-handler/src/node-http2-handler.ts 81.35% <0.00%> (-0.62%) ⬇️
...sal/src/fixtures/MockEventMessageSource.fixture.ts 86.36% <0.00%> (-0.60%) ⬇️
...ream-handler-node/src/EventStreamPayloadHandler.ts 96.00% <0.00%> (-0.30%) ⬇️
packages/hash-node/src/index.ts 100.00% <0.00%> (ø)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d018293...896796c. Read the comment docs.

@trivikr trivikr force-pushed the union-filter-sensitive-log branch from cf28dbe to 896796c Compare July 6, 2020 16:04
@trivikr
Copy link
Member Author

trivikr commented Jul 6, 2020

Blocked on smithy-lang/smithy-typescript#191

@trivikr trivikr changed the title feat: add filterSensitiveLog for Union types feat: [old] add filterSensitiveLog for Union types Aug 18, 2020
@trivikr
Copy link
Member Author

trivikr commented Aug 18, 2020

Created new codegen PR at #1447

@trivikr trivikr closed this Aug 18, 2020
@trivikr trivikr deleted the union-filter-sensitive-log branch August 18, 2020 23:07
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants