Skip to content

Eventstream should be supported in HTTP RPC protocols #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AllanZhengYP opened this issue Jul 6, 2020 · 0 comments
Open

Eventstream should be supported in HTTP RPC protocols #191

AllanZhengYP opened this issue Jul 6, 2020 · 0 comments

Comments

@AllanZhengYP
Copy link
Contributor

AllanZhengYP commented Jul 6, 2020 •
edited
Loading

Currently the event stream serde is only implemented in REST binding protocols, per #110, based on the false assumption that streaming trait is only applicable to REST bindings. However in fact, event stream, AKA union type with streaming trait, should work in both groups of protocols(REST, RPC).

This issue currently results in Kinesis.subscribeToShard doesn't generate with eventstream serde utils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AllanZhengYP @kstich