Skip to content

chore: remove unused world.response from integ tests #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

chore: remove unused world.response from integ tests #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions features/dynamodb/step_definitions/dynamodb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ Given("my first request is corrupted with CRC checking (ON|OFF)", function (
});

Then("the request should( not)? be retried", function (retry, callback) {
if (retry && this.response.retryCount > 0)
if (retry && this.data.$metadata.retries > 0)
callback(new Error("Request was incorrectly retried"));
if (!retry && this.response.retryCount == 0)
if (!retry && this.data.$metadata.retries == 0)
callback(new Error("Request was incorrectly retried"));
callback();
});
Expand All @@ -224,7 +224,7 @@ Given("all of my requests are corrupted with CRC checking ON", function (
});

When("the request is retried the maximum number of times", function (callback) {
if (this.response.retryCount != 2)
if (this.data.$metadata.retries != 2)
callback(new Error("Incorrect retry count"));
callback();
});
Expand Down
1 change: 0 additions & 1 deletion features/extra/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ module.exports = {
if (typeof svc === "string") svc = this[svc];

svc[operation](params, function (err, data) {
world.response = this;
world.error = err;
world.data = data;

Expand Down