Skip to content

chore: remove unused world.response from integ tests #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 10, 2020

Issue #, if available:
N/A

Description of changes:

  • remove unused world.response from integ tests
  • integ tests now use values from this.data.$metadata
  • verified that integ tests are successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1091 into master will increase coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         279      279           
  Lines       11598    11599    +1     
  Branches     2402     2402           
=======================================
+ Hits         9139     9140    +1     
  Misses       2459     2459           
Impacted Files Coverage Δ
...ode/src/fixtures/MockEventMessageSource.fixture.ts 86.36% <0.00%> (ø)
packages/node-http-handler/src/server.mock.ts 76.66% <50.00%> (ø)
packages/hash-stream-node/src/index.ts 90.00% <100.00%> (ø)
packages/middleware-signing/src/middleware.ts 84.37% <100.00%> (ø)
...es/node-http-handler/src/set-connection-timeout.ts 38.46% <100.00%> (ø)
...ckages/node-http-handler/src/set-socket-timeout.ts 100.00% <100.00%> (ø)
packages/signature-v4/src/SignatureV4.ts 100.00% <100.00%> (ø)
packages/smithy-client/src/lazy-json.ts 100.00% <100.00%> (ø)
packages/smithy-client/src/split-every.ts 100.00% <100.00%> (ø)
packages/stream-collector-node/src/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb83c8...14a87e3. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 14a87e3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 1147e0d into aws:master Apr 13, 2020
@trivikr trivikr deleted the remove-world-response branch April 13, 2020 17:00
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants