-
Notifications
You must be signed in to change notification settings - Fork 912
Adding support for Select in ScanEnhancedRequest #5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
123bed6
Adding support for Select in ScanEnhancedRequest
shetsa-amzn 03c883c
Merge branch 'master' into shetsa-amzn/scan_enchanced_select
shetsa-amzn d41865c
Merge branch 'master' into shetsa-amzn/scan_enchanced_select
shetsa-amzn 680af78
Merge branch 'master' into shetsa-amzn/scan_enchanced_select
shetsa-amzn 0e68ce1
Merge branch 'master' into shetsa-amzn/scan_enchanced_select
shetsa-amzn 855a1b4
Merge branch 'master' into shetsa-amzn/scan_enchanced_select
shetsa-amzn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
.changes/next-release/feature-DynamoDBEnhancedClient-da7de1f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"category": "DynamoDB Enhanced Client", | ||
"contributor": "shetsa-amzn", | ||
"type": "feature", | ||
"description": "Adding support for Select in ScanEnhancedRequest" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the "select" enum value isn't known to the SDK version, it would be nice to use 'String' internally, like the code-generated models do. That way, customers that can't upgrade their SDK version can still specify new "select" options we might add in the future.
I see we're not doing that for other enums, and I don't think "select" changes much, so "in a separate PR" is totally fine. Just LMK what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do as part of separate PR for all the Operations where select is used. AFAIK its for Query and Scan.