Adding support for Select in ScanEnhancedRequest #5519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
millems
reviewed
Aug 26, 2024
| @@ -82,6 +82,7 @@ public ScanRequest generateRequest(TableSchema<T> tableSchema, | |||
| .exclusiveStartKey(this.request.exclusiveStartKey()) | |||
| .consistentRead(this.request.consistentRead()) | |||
| .returnConsumedCapacity(this.request.returnConsumedCapacity()) | |||
| .select(this.request.select()) | |||
There was a problem hiding this comment.
In case the "select" enum value isn't known to the SDK version, it would be nice to use 'String' internally, like the code-generated models do. That way, customers that can't upgrade their SDK version can still specify new "select" options we might add in the future.
I see we're not doing that for other enums, and I don't think "select" changes much, so "in a separate PR" is totally fine. Just LMK what you think.
There was a problem hiding this comment.
I think we should do as part of separate PR for all the Operations where select is used. AFAIK its for Query and Scan.
millems
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Select in ScanEnhancedRequest
Motivation and Context
#5382
Modifications
Adding support for Select Attribute in ScanEnhancedRequest
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License