Skip to content

Revert "Add "unsafe" AsyncRequestBody constructors for byte[] and Byt… #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cenedhryn
Copy link
Contributor

…eBuffers (#3925)"

This reverts commit be45eb0.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@cenedhryn cenedhryn requested a review from a team as a code owner June 29, 2023 02:55
@StephenFlavin
Copy link
Contributor

StephenFlavin commented Jun 30, 2023

Hi @cenedhryn,
Would it be possible to know what the motivation for the revert is?
it would re-introduce issue #1735 and conflict with my pr:#4096

@cenedhryn
Copy link
Contributor Author

@StephenFlavin we got a user report where they ran into issues and were linking it to this code, but they have yet to provide a reliable repro case. This PR was created and sitting on standby, but enough days have passed that I think I can close it for now.

@cenedhryn cenedhryn closed this Jul 5, 2023
@StephenFlavin
Copy link
Contributor

Ah, thanks @cenedhryn, happy to help debug if there's an issue in my changes

@cenedhryn cenedhryn deleted the salande/revert-zero-copy-bb branch August 15, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants