Enable zero-copy ByteBuffer publishing in AsyncRequestBody "unsafe" constructors

[StephenFlavin]

Removes guards put in place on #3925 to ensure off-heap buffers were copied to on-heap.
This change to the code enables off-heap buffers to be published directly allowing improved performance zero-copy transfers.

Motivation and Context

see: #3928
This change is effectively running in my own production code where I upload files via MappedByteBuffer, when performance testing I was able to achieve a 25% performance improvement over TransferManager uploading a 1GB file.

Modifications

Removes a condition in ByteBuffersAsyncRequestBody that converts a direct (off-heap) buffer to a non-direct (on-heap) buffer.

Testing

The functionality is covered by existing tests, I've only removed a test which I put in place as a pre-cursor to this change

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[millems]

Sorry about the delay on reviewing this. Looks great! Kicking off the tests...

[StephenFlavin]

No worries @millems, wish I could see that test output 😅

[StephenFlavin]

hey @millems,
with the revert closed could you tell me what the build failure is?

[millems]

@StephenFlavin

It's something silly:

[ERROR] /codebuild/output/src391546243/src/github.com/aws/aws-sdk-java-v2/core/sdk-core/src/main/java/software
/amazon/awssdk/core/internal/async/ByteBuffersAsyncRequestBody.java:28:8: Unused import - 
software.amazon.awssdk.utils.BinaryUtils. [UnusedImports]

[StephenFlavin]

🤦 fixed

[millems]

Rerunning tests

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[millems]

Thanks for your contribution! Sorry about the long time getting it merged.