Skip to content

Fix flaky ProfileFileSupplier test #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jun 21, 2023

This fixes
aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence() by ensuring that that file refresher is always able to see that the file has a new modified time.

Motivation and Context

Modifications

Testing

Tested by running 1000 iterations of the test. Previously, the test would fail around the 25th iteration.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

This fixes
aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence() by
ensuring that that file refresher is always able to see that the file has a new
modified time.
@dagnir dagnir requested a review from a team as a code owner June 21, 2023 20:51
@dagnir dagnir enabled auto-merge (squash) June 21, 2023 21:04
@dagnir dagnir merged commit ad65f95 into master Jun 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@debora-ito debora-ito linked an issue Jul 18, 2023 that may be closed by this pull request
L-Applin pushed a commit that referenced this pull request Jul 24, 2023
This fixes
aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence() by
ensuring that that file refresher is always able to see that the file has a new
modified time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable tests on master
2 participants