Skip to content

Unstable tests on master #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
StephenFlavin opened this issue Apr 20, 2023 · 6 comments · Fixed by #4127 or #4206
Open

Unstable tests on master #3926

StephenFlavin opened this issue Apr 20, 2023 · 6 comments · Fixed by #4127 or #4206
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@StephenFlavin
Copy link
Contributor

StephenFlavin commented Apr 20, 2023 •
edited
Loading

Describe the bug

mvn install was failing on SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe and ProfileFileSupplierTest#aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence there may be more.

I came across this while doing the PR checklist.

Expected Behavior

the master branch has repeatable tests that don't fail

Current Behavior

a couple of flakey test preventing builds, the flakeyness might be the result of a wider issue

Reproduction Steps

Run SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe on repeat

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

2.20.50-SNAPSHOT

JDK version used

openjdk 11.0.16.1 & openjdk 19.0.1

Operating System and version

macOs 13.2.1 (22D68)
@StephenFlavin StephenFlavin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2023
@StephenFlavin StephenFlavin mentioned this issue Apr 20, 2023
Merged
12 tasks
@debora-ito
Copy link
Member

Are they flaky or they fail every time?
Can you post the logs with the error?

@debora-ito debora-ito added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2023
@debora-ito debora-ito self-assigned this Apr 21, 2023
@StephenFlavin
Copy link
Contributor Author

StephenFlavin commented Apr 21, 2023 •
edited
Loading

flaky sorry if I was unclear.
Screenshot 2023-04-21 at 08 50 32

Screenshot 2023-04-21 at 08 54 32

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Apr 21, 2023
@debora-ito
Copy link
Member

@StephenFlavin Thank you for the logs. We'll change them to make less flaky.

@debora-ito debora-ito removed their assignment Apr 21, 2023
@debora-ito debora-ito added the p2 This is a standard priority issue label Apr 21, 2023
@StephenFlavin
Copy link
Contributor Author

StephenFlavin commented May 23, 2023 •
edited
Loading

also CachedSupplierTest.nonBlockingPrefetchStrategyHasOneMinuteMinimumByDefault
Screenshot 2023-05-23 at 14 21 55

@StephenFlavin StephenFlavin changed the title Unstable tests on master? Unstable tests on master May 23, 2023
@StephenFlavin
Copy link
Contributor Author

just spotted this failing on the github runner for the last release https://github.com/aws/aws-sdk-java-v2/actions/runs/5516177879/jobs/10057255204#step:3:43966

@debora-ito debora-ito linked a pull request Jul 18, 2023 that will close this issue
Fix flaky ProfileFileSupplier test #4127
Merged
12 tasks
@debora-ito debora-ito linked a pull request Jul 26, 2023 that will close this issue
Fix flaky test: SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe #4206
Merged
@debora-ito
Copy link
Member

SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe and ProfileFileSupplierTest#aggregate_duplicateOptionsGivenReloadingProfileFirst_preservesPrecedence flakiness were fixed and merged.

Will take a look at CachedSupplierTest.nonBlockingPrefetchStrategyHasOneMinuteMinimumByDefault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
2 participants
@debora-ito @StephenFlavin