Add Endpoint & TlsContext to S3ClientConfiguration used by S3TransferManager

[ron1]

Motivation and Context

Resolves #2945
Also resolves #2740 and #2896

Description

Add Endpoint and TlsContext to S3ClientConfiguration used by S3TransferManager

Testing

Tested locally.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

3.8% Coverage
0.0% Duplication

[medjaoua]

Hello,

Can we have a date for validation of this pull request.
I have to add the endpoint in these classes and if done, it will be helpful a lot.

Thanks in advance.

Best Regards,

[zoewangg]

Apologies for the delayed response and thank you for your interest in contributing to our project. We are actually working on refactoring on the configuration of the transfer manager; we are planning to remove S3Configuration from the transfer manager builder and allow users to pass the S3AsyncClient where they can configure the endpoint and other settings directly. This way, you don't have to configure the same settings twice on the S3 client as well as the transfer manager.

We will close this PR for now. We appreciate your time and effort spent on this! :)

[ron1]

@zoewangg Do you know if the refactored S3TransferManager will require a CRT-based S3AsyncClient?

[zoewangg]

@ron1 The current design is that S3TransferManager will create a CRT based S3AsyncClient by default, but users can pass an instance of S3AsyncClient to it, CRT based or Java based. Would this work for your use-case? We'd love to hear more if you have additional feedback.

[ron1]

@zoewangg Yes, enabling S3TransferManager to consume any S3AsyncClient instance, CRT-based or not, will work for us.