Skip to content

S3TransferManager ability to set endpointOverride #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehmurray8 opened this issue Sep 25, 2021 · 5 comments
Closed

S3TransferManager ability to set endpointOverride #2740

ehmurray8 opened this issue Sep 25, 2021 · 5 comments
Labels
feature-request A feature should be added or improved. transfer-manager

Comments

@ehmurray8
Copy link

Describe the Feature

With the S3AsyncClient I am able to set the endpointOverride like this.

S3AsyncClient.builder().endpointOverride(URI("http://minio-s3:9000"))

I can't find a way to do the same thing with S3TransferManager.

Is your Feature Request related to a problem?

When running my project locally I am using Minio to mock S3 locally, and I need to be able to send requests to it.

Proposed Solution

I would like to be able to do the same thing with S3TransferManager

 S3TransferManager.builder()
        .s3ClientConfiguration { cfg ->
            cfg.endpointOverride(URI("http://minio-s3:9000"))
        }

Your Environment

  • AWS Java SDK version used: 2.17.46-PREVIEW
  • JDK version used: 16.0.2
  • Operating System and version: Mac M1
@ehmurray8 ehmurray8 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2021
@zoewangg zoewangg added transfer-manager and removed needs-triage This issue or PR still needs to be triaged. labels Sep 27, 2021
@debora-ito
Copy link
Member

Thank you for reaching out @ehmurray8. Feature request acknowledged.

@aceeric
Copy link

aceeric commented Dec 22, 2021

This would be valuable for us as well. Presently, we are using the S3AsyncClient to download 10K-sized objects from Minio because the class supports the endpoint override. The best we can get this way is 4MiB/sec for downloads. In comparison, using the s5cmd utility as a performance benchmark, we are able to get 38MiB/sec performing the same downloads. I'm wondering if the difference is partially due to the S3 Transfer Manager's optimization of multipart downloads.

@openwebsolns
Copy link

Is there an update on this feature request?

@zoewangg
Copy link
Contributor

Implemented in #3084. Closing the issue

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

aws-sdk-java-automation added a commit that referenced this issue Nov 3, 2023
…7d1def9f0

Pull request: release <- staging/d7a35f87-ddc2-4cce-94cf-b5e7d1def9f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. transfer-manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants