Metric utils test #1906
Merged
Metric utils test #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
metric-utils-test
branch
from
9294912 to
1ce3eec
Compare
Follow-up on review comment on aws#1882
dagnir
force-pushed
the
metric-utils-test
branch
from
1ce3eec to
b9b7faa
Compare
|
SonarCloud Quality Gate failed.
|
cenedhryn
reviewed
Jun 18, 2020
Comment on lines
+119
to
+120
| verify(mockCollector).reportMetric(CoreMetric.AWS_REQUEST_ID, requestId); | ||
| verify(mockCollector).reportMetric(CoreMetric.AWS_REQUEST_ID, amznRequestId); |
There was a problem hiding this comment.
Why do we report the same metric with two different values?
There was a problem hiding this comment.
Depending on the service, the Header used for the request ID can be differ between these two values. This is just to ensure we're catching both cases, I don't think a service will use both.
cenedhryn
approved these changes
Jun 18, 2020
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 22, 2022
…f9aff9e0b Pull request: release <- staging/d48fd9ff-6141-4e4a-8e2a-8cdf9aff9e0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on review comment on #1882
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense