Support core metrics for sync clients #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
cenedhryn
reviewed
Jun 8, 2020
...test/java/software/amazon/awssdk/core/client/AsyncClientHandlerInterceptorExceptionTest.java
Show resolved
Hide resolved
| @@ -271,4 +286,12 @@ static void validateExecutionParams(ClientExecutionParams<?, ?> executionParams) | |||
| BiFunction<T, R, T> function2) { | |||
| return (x, y) -> function2.apply(function1.apply(x, y), y); | |||
| } | |||
|
|
|||
| private MetricCollector resolveMetricCollector(ClientExecutionParams<?, ?> params) { | |||
There was a problem hiding this comment.
can we move this recurring resolver to a utils class or is that inconsistent with our core coding patterns?
| * Utility methods for working with metrics. | ||
| */ | ||
| @SdkInternalApi | ||
| public final class MetricUtils { |
There was a problem hiding this comment.
Does this class have a unit test file?
core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/util/MetricUtils.java
Show resolved
Hide resolved
...ses-test/src/test/java/software/amazon/awssdk/services/protocolrestjson/CoreMetricsTest.java
Show resolved
Hide resolved
zoewangg
reviewed
Jun 8, 2020
core/sdk-core/src/main/java/software/amazon/awssdk/core/metrics/CoreMetric.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/metrics/CoreMetric.java
Show resolved
Hide resolved
zoewangg
approved these changes
Jun 8, 2020
|
Per discussion with @zoewangg going to merge this PR now since the outstanding comments are minor so she can get started on async metrics. Will address the comments here in a follow up PR. |
zoewangg
reviewed
Jun 9, 2020
.../test/resources/software/amazon/awssdk/codegen/poet/client/test-endpoint-discovery-sync.java
Show resolved
Hide resolved
zoewangg
reviewed
Jun 10, 2020
...-core/src/main/java/software/amazon/awssdk/awscore/client/handler/AwsClientHandlerUtils.java
Show resolved
Hide resolved
zoewangg
reviewed
Jun 10, 2020
...ses-test/src/test/java/software/amazon/awssdk/services/protocolrestjson/CoreMetricsTest.java
Show resolved
Hide resolved
dagnir
added a commit
to dagnir/aws-sdk-java-v2
that referenced
this pull request
Jun 18, 2020
Follow-up on review comment on aws#1882
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 21, 2021
…a8f6000ba Pull request: release <- staging/e6f8c2a2-d913-4fb6-b322-03ca8f6000ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commits adds collection of core metrics for sync clients.
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense