Aws crt dev preview

[bretambrose]

Add support for an http client based on the AWS Common Runtime.

Description

This PR replaces #1607

This PR adds support for TLS negotiation post-quantum cryptographic suites as offered by Amazon KMS. The AWS Common Runtime provides an http client that uses s2n as its TLS implementation, and s2n in turn supports the necessary post-quantum cipher suites.

https://aws.amazon.com/blogs/security/post-quantum-tls-now-supported-in-aws-kms/

https://aws.amazon.com/blogs/security/round-2-hybrid-post-quantum-tls-benchmarks/

Testing

mvn clean install

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[codecov-io]

Codecov Report

Merging #1777 into master will increase coverage by 0.10%.
The diff coverage is 84.91%.

@@             Coverage Diff              @@
##             master    #1777      +/-   ##
============================================
+ Coverage     76.29%   76.39%   +0.10%     
  Complexity      182      182              
============================================
  Files          1072     1078       +6     
  Lines         32252    32669     +417     
  Branches       2520     2570      +50     
============================================
+ Hits          24607    24959     +352     
- Misses         6404     6437      +33     
- Partials       1241     1273      +32     

Flag	Coverage Δ	Complexity Δ
#unittests	76.39% <84.91%> (+0.10%)	182.00 <0.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
.../enhanced/dynamodb/model/QueryEnhancedRequest.java	61.64% <64.70%> (+0.24%)	0.00 <0.00> (ø)
...k/enhanced/dynamodb/model/ScanEnhancedRequest.java	61.40% <64.70%> (+0.42%)	0.00 <0.00> (ø)
...http/crt/internal/AwsCrtRequestBodySubscriber.java	78.00% <78.00%> (ø)	0.00 <0.00> (?)
.../amazon/awssdk/http/crt/AwsCrtAsyncHttpClient.java	79.52% <79.52%> (ø)	0.00 <0.00> (?)
...http/crt/internal/AwsCrtResponseBodyPublisher.java	88.46% <88.46%> (ø)	0.00 <0.00> (?)
...etty/internal/http2/Http2ToHttpInboundAdapter.java	71.87% <90.90%> (+8.23%)	0.00 <0.00> (ø)
...ttp/crt/internal/AwsCrtAsyncHttpStreamAdapter.java	93.61% <93.61%> (ø)	0.00 <0.00> (?)
...p/crt/internal/AwsCrtResponseBodySubscription.java	100.00% <100.00%> (ø)	0.00 <0.00> (?)
...wssdk/http/nio/netty/internal/ResponseHandler.java	89.30% <100.00%> (+0.20%)	0.00 <0.00> (ø)
...nal/http2/Http2ConnectionTerminatingException.java	100.00% <100.00%> (ø)	0.00 <0.00> (?)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fcc4f...98fcc4f. Read the comment docs.

[zoewangg]

Preliminary review, still going through the PR.

Can we add some stability tests for s3 and sqs? The stability tests are used to detect regressions with high concurrent requests. We have the harness, and it should be fairly easy to add new tests with StabilityTestRunner

[zoewangg]

This can be confused with h2 intialWindowSize.

[bretambrose]

I'm updating the comment here to better reflect this setting, which actually corresponds to what's described for h1, but will correspond to h2 initialWindowSize for h2 connections. It's not clear what changes will need to be made to fold h2 into the crt client, so for now I'd prefer to leave this be and readdress it (two params? one param with additional per-version comments?) as h2 gets brought in.

[zoewangg]

Just curious, why do we need to invoke initRespBodyPublisherIfNeeded in every method?

[bretambrose]

No clue! We might be able to remove some (onResponseHeaders at least), but am not sure beyond that. I can ping Alex on this.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
11 Code Smells

80.1% Coverage
2.5% Duplication

The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here