Skip to content

Remove unnecessary copy #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Remove unnecessary copy #1888

merged 2 commits into from
Jun 11, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jun 10, 2020

Description

Fixes #1877

Motivation and Context

Testing

New unit test.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #1888 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1888      +/-   ##
============================================
+ Coverage     76.21%   76.30%   +0.08%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32568    32568              
  Branches       2569     2569              
============================================
+ Hits          24822    24850      +28     
+ Misses         6488     6465      -23     
+ Partials       1258     1253       -5     
Flag Coverage Δ Complexity Δ
#unittests 76.30% <100.00%> (+0.08%) 187.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...are/amazon/awssdk/core/async/AsyncRequestBody.java 81.81% <100.00%> (ø) 0.00 <0.00> (ø)
...o/netty/internal/utils/BetterFixedChannelPool.java 58.04% <0.00%> (+1.72%) 0.00% <0.00%> (ø%)
.../http/nio/netty/internal/NettyRequestExecutor.java 74.24% <0.00%> (+5.55%) 0.00% <0.00%> (ø%)
...http/nio/netty/internal/nrs/HandlerSubscriber.java 82.75% <0.00%> (+6.89%) 0.00% <0.00%> (ø%)
...k/core/pagination/async/ResponsesSubscription.java 84.00% <0.00%> (+16.00%) 0.00% <0.00%> (ø%)
...mazon/awssdk/utils/async/DelegatingSubscriber.java 100.00% <0.00%> (+22.22%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b679524...b5adbd9. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@dagnir dagnir merged commit 1ba3e7b into aws:master Jun 11, 2020
@dagnir dagnir deleted the 1877 branch June 11, 2020 00:12
aws-sdk-java-automation added a commit that referenced this pull request Jan 7, 2022
…920b4cfd2

Pull request: release <- staging/2a587cdd-4a1e-41da-be5d-427920b4cfd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncRequestBody.fromBytes will copy the given buffer twice
3 participants