Update default connectionMaxIdleTimeout for NettyNioAsyncClient

.changes/next-release/bugfix-NettyNIOHTTPClient-40d6c38.json

@@ -0,0 +1,5 @@
+{
+    "category": "Netty NIO HTTP Client", 
+    "type": "bugfix", 
+    "description": "Update default connectionMaxIdleTimeout of NettyNioAsyncClient to 5 seconds"
+}

http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java

@@ -78,6 +78,12 @@ public final class NettyNioAsyncHttpClient implements SdkAsyncHttpClient {
     private static final Logger log = LoggerFactory.getLogger(NettyNioAsyncHttpClient.class);
     private static final long MAX_STREAMS_ALLOWED = 4294967295L; // unsigned 32-bit, 2^32 -1
 
+    // Override connection idle timeout for Netty http client to reduce the frequency of "server failed to complete the
+    // response error". see https://github.com/aws/aws-sdk-java-v2/issues/1122
+    private static final AttributeMap NETTY_HTTP_DEFAULTS = AttributeMap.builder()
+                                                                        .put(CONNECTION_MAX_IDLE_TIMEOUT, Duration.ofSeconds(5))
+                                                                        .build();
+
     private final SdkEventLoopGroup sdkEventLoopGroup;
     private final SdkChannelPoolMap<URI, ? extends ChannelPool> pools;
     private final NettyConfiguration configuration;
@@ -175,6 +181,11 @@ public String clientName() {
         return CLIENT_NAME;
     }
 
+    @SdkTestInternalApi
+    NettyConfiguration configuration() {
+        return configuration;
+    }
+
     /**
      * Builder that allows configuration of the Netty NIO HTTP implementation. Use {@link #builder()} to configure and construct
      * a Netty HTTP client.
@@ -561,6 +572,7 @@ public Builder tlsKeyManagersProvider(TlsKeyManagersProvider tlsKeyManagersProvi
         public SdkAsyncHttpClient buildWithDefaults(AttributeMap serviceDefaults) {
             return new NettyNioAsyncHttpClient(this, standardOptions.build()
                                                                     .merge(serviceDefaults)
+                                                                    .merge(NETTY_HTTP_DEFAULTS)
                                                                     .merge(SdkHttpConfigurationOption.GLOBAL_HTTP_DEFAULTS));
 
         }

http-clients/netty-nio-client/src/test/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClientWireMockTest.java

@@ -113,6 +113,22 @@ public static void tearDown() throws Exception {
         client.close();
     }
 
+    @Test
+    public void defaultConnectionIdleTimeout() {
+        try (NettyNioAsyncHttpClient client = (NettyNioAsyncHttpClient) NettyNioAsyncHttpClient.builder().build()) {
+            assertThat(client.configuration().idleTimeoutMillis()).isEqualTo(5000);
+        }
+    }
+
+    @Test
+    public void overrideConnectionIdleTimeout_shouldHonor() {
+        try (NettyNioAsyncHttpClient client = (NettyNioAsyncHttpClient) NettyNioAsyncHttpClient.builder()
+                                                                                               .connectionMaxIdleTime(Duration.ofMillis(1000))
+                                                                                               .build()) {
+            assertThat(client.configuration().idleTimeoutMillis()).isEqualTo(1000);
+        }
+    }
+
     @Test
     public void customFactoryIsUsed() throws Exception {
         ThreadFactory threadFactory = spy(new CustomThreadFactory());

services/cloudwatch/src/main/resources/codegen-resources/customization.config

@@ -9,6 +9,5 @@
     "deleteDashboards",
     "putDashboard",
     "getDashboard"
-  ],
-  "serviceSpecificHttpConfig": "software.amazon.awssdk.services.cloudwatch.internal.CloudWatchHttpConfigurationOptions"
+  ]
 }

services/s3/src/main/resources/codegen-resources/customization.config

@@ -85,6 +85,5 @@
     "createMethodParams": [
       "clientConfiguration"
     ]
-  },
-  "serviceSpecificHttpConfig": "software.amazon.awssdk.services.s3.internal.S3HttpConfigurationOptions"
+  }
 }