Skip to content

Update default connectionMaxIdleTimeout for NettyNioAsyncClient #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Nov 15, 2019

Description

Update default connectionMaxIdleTimeout for NettyNioAsyncClient to 5 seconds

Motivation and Context

#1122

Testing

Added unit tests.
Will run integ tests, stability tests.
Integ tests, stability tests passed

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Contributor

@bmaizels bmaizels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have preferred us not to have to add a package protected accessor to prove it was working correctly, but accept that testing default configuration values with behavioral tests is not easy.

@zoewangg zoewangg merged commit d6b7ecc into master Nov 18, 2019
@zoewangg zoewangg deleted the master-zoewang-nettyDefaultMaxConnectionIdleTimeout branch November 26, 2019 22:39
aws-sdk-java-automation added a commit that referenced this pull request Jul 2, 2021
…e1b5f1b6a

Pull request: release <- staging/5a0e4661-cd23-4b2c-bcc8-c15e1b5f1b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants