Enable client TLS auth for Netty

[dagnir]

Description

This commit enables customers to configure a TlsKeyManagersProvider on the Netty
client which will be used to authenticate the client during client TLS
authentication.

Motivation and Context

Part of new feature, see #858.

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

Note, builds on #1379, #1384, so those should be merged first.

[dagnir]

BTW the JDK11 failure in Travis

[ERROR] Redundant nullcheck of storeIs, which is known to be non-null in software.amazon.awssdk.internal.http.AbstractFileStoreTlsKeyManagersProvider.createKeyStore(Path, String, char[]) [software.amazon.awssdk.internal.http.AbstractFileStoreTlsKeyManagersProvider, software.amazon.awssdk.internal.http.AbstractFileStoreTlsKeyManagersProvider] Redundant null check at AbstractFileStoreTlsKeyManagersProvider.java:[line 50]Another occurrence at AbstractFileStoreTlsKeyManagersProvider.java:[line 53] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

appears to caused by this open bug in SpotBugs: spotbugs/spotbugs#756

It's complaining about this bit:

aws-sdk-java-v2/http-client-spi/src/main/java/software/amazon/awssdk/internal/http/AbstractFileStoreTlsKeyManagersProvider.java

Lines 50 to 53 in 93269d4

	try (InputStream storeIs = Files.newInputStream(storePath)) {
	ks.load(storeIs, password);
	return ks;
	}

[codecov-io]

Codecov Report

Merging #1390 into master will increase coverage by 0.05%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master    #1390      +/-   ##
============================================
+ Coverage     71.13%   71.19%   +0.05%     
- Complexity      650      654       +4     
============================================
  Files           839      843       +4     
  Lines         26538    26608      +70     
  Branches       2091     2097       +6     
============================================
+ Hits          18879    18943      +64     
- Misses         6795     6804       +9     
+ Partials        864      861       -3

Flag	Coverage Δ	Complexity Δ
#unittests	71.19% <86.66%> (+0.05%)	654 <4> (+4)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...amazon/awssdk/http/SdkHttpConfigurationOption.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...are/amazon/awssdk/http/TlsKeyManagersProvider.java	100% <100%> (ø)	1 <1> (?)
...ssdk/internal/http/NoneTlsKeyManagersProvider.java	100% <100%> (ø)	3 <3> (?)
...tp/nio/netty/internal/StaticKeyManagerFactory.java	100% <100%> (ø)	0 <0> (?)
...awssdk/http/nio/netty/NettyNioAsyncHttpClient.java	65.89% <100%> (+0.53%)	0 <0> (ø)	⬇️
...nio/netty/internal/StaticKeyManagerFactorySpi.java	100% <100%> (ø)	0 <0> (?)
...dk/http/nio/netty/internal/NettyConfiguration.java	93.33% <100%> (+0.47%)	0 <0> (ø)	⬇️
...re/amazon/awssdk/http/apache/ApacheHttpClient.java	75.4% <100%> (+0.4%)	0 <0> (ø)	⬇️
...p/nio/netty/internal/AwaitCloseChannelPoolMap.java	89.65% <83.33%> (+0.56%)	0 <0> (ø)	⬇️
...tomization/CodegenCustomizationProcessorChain.java	81.81% <0%> (-8.19%)	0% <0%> (ø)
... and 50 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313c15e...d101175. Read the comment docs.

[millems]

Is this still needed now that we have mergeDefaults?

[millems]

lgtm, other than the one small comment