-
Notifications
You must be signed in to change notification settings - Fork 910
Enable HTTP proxying for Netty client #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
============================================
+ Coverage 70.93% 71.06% +0.13%
Complexity 188 188
============================================
Files 781 785 +4
Lines 24442 24583 +141
Branches 1836 1841 +5
============================================
+ Hits 17338 17471 +133
+ Misses 6310 6309 -1
- Partials 794 803 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests missing for the boring stuff like builders and toBuilder() etc.
...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMap.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMap.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMap.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/http/nio/netty/internal/Http1TunnelConnectionPool.java
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/http/nio/netty/internal/ProxyTunnelInitHandlerTest.java
Outdated
Show resolved
Hide resolved
...-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java
Show resolved
Hide resolved
.../netty-nio-client/src/test/java/software/amazon/awssdk/http/nio/netty/ProxyWireMockTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only actual blocker is the threadsafe thing. The other stuff is minor.
...-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMap.java
Show resolved
Hide resolved
...netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/ProxyConfiguration.java
Show resolved
Hide resolved
...t/src/main/java/software/amazon/awssdk/http/nio/netty/internal/AwaitCloseChannelPoolMap.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking: as discussed I would have preferred you to test the caching behavior without injecting a cache, just from the outside as I don't think it's necessary to assert that the cache is actually being used just that it's not breaking the class.
Can we please enable proxy config for the DynamoDbAsyncClient dor aws-java sdk 2.x |
Description
Enable HTTP proxying for Netty client.
Motivation and Context
New feature. See #858.
Testing
New unit tests, manual testing against proxy server.
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense