Skip to content

Enable HTTP proxying for Netty client #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Aug 15, 2019

Description

Enable HTTP proxying for Netty client.

Motivation and Context

New feature. See #858.

Testing

New unit tests, manual testing against proxy server.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #1384 into master will increase coverage by 0.13%.
The diff coverage is 90.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1384      +/-   ##
============================================
+ Coverage     70.93%   71.06%   +0.13%     
  Complexity      188      188              
============================================
  Files           781      785       +4     
  Lines         24442    24583     +141     
  Branches       1836     1841       +5     
============================================
+ Hits          17338    17471     +133     
+ Misses         6310     6309       -1     
- Partials        794      803       +9
Flag Coverage Δ Complexity Δ
#unittests 71.06% <90.65%> (+0.13%) 188 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...awssdk/http/nio/netty/NettyNioAsyncHttpClient.java 65.35% <60%> (-0.22%) 0 <0> (ø)
...azon/awssdk/http/nio/netty/ProxyConfiguration.java 79.59% <79.59%> (ø) 0 <0> (?)
...ty/internal/SimpleChannelPoolAwareChannelPool.java 90.9% <90.9%> (ø) 0 <0> (?)
...p/nio/netty/internal/AwaitCloseChannelPoolMap.java 89.09% <90.9%> (+1.74%) 0 <0> (ø) ⬇️
...ttp/nio/netty/internal/ProxyTunnelInitHandler.java 97.29% <97.29%> (ø) 0 <0> (?)
.../nio/netty/internal/Http1TunnelConnectionPool.java 98.24% <98.24%> (ø) 0 <0> (?)
...ssdk/core/internal/async/FileAsyncRequestBody.java 80.95% <0%> (-3.81%) 0% <0%> (ø)
...mazon/awssdk/core/internal/retry/RetryHandler.java 88.63% <0%> (-2.28%) 0% <0%> (ø)
...ery/internal/marshall/QueryMarshallerRegistry.java 77.77% <0%> (-2.23%) 0% <0%> (ø)
...awssdk/codegen/poet/client/specs/ProtocolSpec.java 81.57% <0%> (-2.15%) 0% <0%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92083c6...843a87b. Read the comment docs.

Copy link
Contributor

@bmaizels bmaizels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests missing for the boring stuff like builders and toBuilder() etc.

Copy link
Contributor

@bmaizels bmaizels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only actual blocker is the threadsafe thing. The other stuff is minor.

Copy link
Contributor

@bmaizels bmaizels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking: as discussed I would have preferred you to test the caching behavior without injecting a cache, just from the outside as I don't think it's necessary to assert that the cache is actually being used just that it's not breaking the class.

@dagnir dagnir merged commit 039d98f into aws:master Aug 20, 2019
@BhargavChoksi
Copy link

Can we please enable proxy config for the DynamoDbAsyncClient dor aws-java sdk 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants