Metrics: Add interfaces and initial implementations #1314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty policies set on custom domain resources in API Gateway
…indows File Server file systems to your organization's self-managed Microsoft Active Directory while creating the file system. You can also perform in-place updates of file systems to keep your Active Directory configuration up to date.
…r the EnableSecurityHub operation, and the following new operations: DescribeHub, CreateActionTarget, DeleteActionTarget, DescribeActionTargets, UpdateActionTarget, TagResource, UntagResource, and ListTagsforResource. It removes the operation ListProductSubscribers, and makes Title and Description required attributes of AwsSecurityFinding.
…your quotas for AWS services from a central location.
…etwork Load Balancers
…cies (TLS version + cipher suite) for custom domains in API Gateway
…upports deleting a specific version of a SSM Document.
… Insights detects errors and exceptions from logs, including .NET custom application logs, SQL Server logs, IIS logs, and more, and uses a combination of built-in rules and machine learning, such as dynamic baselining, to identify common problems. You can then easily drill into specific issues with CloudWatch Automatic Dashboards that are dynamically generated. These dashboards contain the most recent alarms, a summary of relevant metrics, and log snippets to help you identify root cause.
…8983fb30 Pull request: release <- staging/b6131469-5d95-4d77-97e7-45108983fb30
…eld names, even if they differ in capitalization.
…fic Mirroring to copy network traffic from an elastic network interface of Amazon EC2 instances and then send it to out-of-band security and monitoring appliances for content inspection, threat monitoring, and troubleshooting. These appliances can be deployed as individual instances, or as a fleet of instances behind a Network Load Balancer with a User Datagram Protocol (UDP) listener. Traffic Mirroring supports filters and packet truncation, so that you only extract the traffic of interest to monitor by using monitoring tools of your choice.
…rvice name to Amazon Elastic Kubernetes Service.
…b727c9d3 Pull request: release <- staging/66c3a79a-c1fa-4328-af74-9b46b727c9d3
…oke from publisher and we should let the subscriber to handle the cancellation
…educe the number of test failures due to eventual consistency on the IAM side being slow.
…atewayV2 Resources (typically associated with WebSocket APIs)
…c7d8e32d Pull request: release <- staging/ca1f986f-55eb-49fb-8bf5-40afc7d8e32d
…65ef9b07 Pull request: release <- staging/6386348e-edae-4494-89cf-efc865ef9b07
zoewangg
reviewed
Jul 19, 2019
| /** | ||
| * Service ID of the AWS service that the API request is made against | ||
| */ | ||
| Service("Service", DEFAULT), |
There was a problem hiding this comment.
This enum class also needs to be updated to use all caps
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/meter/DefaultGauge.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/metrics/provider/DefaultMetricConfigurationProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/metrics/provider/MetricConfigurationProviderChain.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public boolean remove(String name) { | ||
| Metric metric = metrics.remove(name); |
There was a problem hiding this comment.
Can we just do return metrics.remove(name)?
| /** | ||
| * Return an ordered list of {@link MetricRegistry} instances recorded for each Api Call Attempt in the request execution. | ||
| * Each Api call attempt metrics are recorded as a separate {@link MetricRegistry} instance in the given list. | ||
| * |
There was a problem hiding this comment.
missing <p>. I think there are other places also missing the tag. Can you do a global check?
There was a problem hiding this comment.
Added in few classes that I noticed. Also realized the <p> don't need an end tag
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/meter/NoOpCounter.java
Outdated
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/meter/NoOpTimer.java
Outdated
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/meter/NoOpGauge.java
Outdated
Show resolved
Hide resolved
varunnvs92
force-pushed
the
varunkn/metrics-design
branch
from
a6639e7 to
4c959a5
Compare
…d top contributor types to describe WordPress Pingback DDoS attacks.
… offer server-side encryption. You can now select your own customer managed CMK, or use an AWS managed CMK in your KMS account.
…6c7dab8b Pull request: release <- staging/45422c33-dd9a-414c-a62c-37cb6c7dab8b
…d size of SecretString or SecretBinary from 7KB to 10KB in the CreateSecret, UpdateSecret, PutSecretValue and GetSecretValue APIs. This release also increases the maximum allowed size of ResourcePolicy from 4KB to 20KB in the GetResourcePolicy and PutResourcePolicy APIs.
…ce Windows to select a resource group as the target. By selecting a resource group as the target of a Maintenance Window, customers can perform routine tasks across different resources such as Amazon Elastic Compute Cloud (AmazonEC2) instances, Amazon Elastic Block Store (Amazon EBS) volumes, and Amazon Simple Storage Service(Amazon S3) buckets within the same recurring time window.
…c9949224 Pull request: release <- staging/696c80d2-8f96-42ac-b20a-6a88c9949224
…cess to many of the same campaign metrics that are displayed on the Amazon Pinpoint console. You can now use the Amazon Pinpoint API to monitor and assess performance data for campaigns, and integrate metrics data with other reporting tools. We update the metrics data continuously, resulting in a data latency timeframe that is limited to approximately two hours.
…for split tunnel with AWS Client VPN, and also adds support for opt-in Regions in DescribeRegions API. In addition, customers can now also tag Launch Templates on creation.
…tion that returns the account identifier for the specified access key ID.
…s and WorkerType option for DevEndpoint APIs. Job APIs enable users to pick specific GlueVersion for a specific job and pin the job to a specific runtime environment. DevEndpoint APIs enable users to pick different WorkerType for memory intensive workload.
…d6e3f28b Pull request: release <- staging/d55fe5a4-0306-43a3-8289-8764d6e3f28b
spfink
force-pushed
the
varunkn/metrics-design
branch
2 times, most recently
from
2a7e227 to
e7226a4
Compare
spfink
force-pushed
the
varunkn/metrics-design
branch
from
e7226a4 to
739682f
Compare
|
Closing in favor of: #1362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.