aws credentials cleanup #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
reviewed
Jun 22, 2018
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(accessKeyId, secretAccessKey); |
There was a problem hiding this comment.
Not a big deal, but we should prefer Objects.hashCode since Objects#hash needs to create a temporary array
There was a problem hiding this comment.
yeah, sure, good call, was not aware of it. I'll fix it and it might be a be a good idea to add a checkstyle for this.
|
Thanks for adding a checkstyle rule! |
…ls and AwsSessionCredentials. Rename getCredentials to resolveCredentials
zoewangg
force-pushed
the
zoewang-awsSessionCredentials
branch
from
461083f to
864a6bd
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 24, 2019
…d6e3f28b Pull request: release <- staging/d55fe5a4-0306-43a3-8289-8764d6e3f28b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
AwsSessionCredentialsextendsAwsCredentials, but it's really not a is-a relation and the inheritance has many issues/limitations, eg: inherited static factory methods.AwsCredentialsto interfaceAwsSessionCredentialsimplementsAwsCredentialsAwsBasicCredentialsimplementsAwsCredentialsAwsBasicCredentialsclass is namedBasicAwsCredentialsin v1. I named it this way to match AwsSessionCredentials, but this is open to discussion.getCredentials()toresolveCredentials()as we discussed.will create changelog entry before merge