Skip to content

Bump Python CRT for better arm64 support #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump Python CRT for better arm64 support #323

wants to merge 1 commit into from

Conversation

TwistedTwigleg
Copy link
Contributor

Description of changes:

Changes from PR #332, but made as a branch so CI runs. Description from #332:

The recent arm64 support for awscrt isn't working 100%.
I get the following with 0.13.11:

        building '_awscrt' extension
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-mqtt.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-http.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-s3.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-auth.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-event-stream.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-compression.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-checksums.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-cal.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-sdkutils.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-io.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-common.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64

The latest version of awscrt, 0.13.13 resolves this and it builds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TwistedTwigleg
Copy link
Contributor Author

Merged the original PR after successful CI run and local tests. Closing...

@TwistedTwigleg TwistedTwigleg deleted the PythonCrtVersionBump branch June 15, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwistedTwigleg @peteward