Skip to content

further awscrt bump for arm64 support #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2022
Merged

further awscrt bump for arm64 support #322

merged 1 commit into from
Jun 15, 2022

Conversation

peteward
Copy link
Contributor

Description of changes:

The recent arm64 support for awscrt isn't working 100%.
I get the following with 0.13.11:

        building '_awscrt' extension
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-mqtt.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-http.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-s3.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-auth.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-event-stream.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-compression.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-checksums.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-cal.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-sdkutils.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-io.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
        ld: warning: ignoring file build/temp.macosx-10.14-arm64-3.8/deps/install/lib/libaws-c-common.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64

The latest version of awscrt, 0.13.13 resolves this and it builds.

@jmklix jmklix changed the title further awscert bump for arm64 support further awscrt bump for arm64 support Jun 14, 2022
@TwistedTwigleg TwistedTwigleg mentioned this pull request Jun 15, 2022
Closed
TwistedTwigleg
TwistedTwigleg approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@TwistedTwigleg TwistedTwigleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit 9c2c6d8 into aws:main Jun 15, 2022
@peteward peteward deleted the awscert-arm64 branch June 15, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwistedTwigleg TwistedTwigleg TwistedTwigleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteward @TwistedTwigleg @jmklix