Base class for MqttServiceClients #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles dispatching responses to requests based on "nonce" aka "client token".
Raise error if topic label is missing.
justinboswell
approved these changes
Dec 11, 2018
DavidOgunsAWS
pushed a commit
that referenced
this pull request
Dec 15, 2020
* simplify model - enums are just strings, like in oldschool python. solves forward compatibility issues - remove _ExplicitlyNullMixin, explicit null is only needed in document types, which support it without this madness - remove _UnionMixin. Let the service validate it. Might revamp unions anyway * simpler __eq__ * type hints * comment public API
bretambrose
added a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most RPC operations use a "nonce" aka "client token" so a response can be associated with a particular request.
For operations that don't use a nonce, a response is associated with whichever request has been waiting the longest, aka "FIFO".
There's a lot of copy/pasted code for handling Nonce vs FIFO operations. This will get cleaned up when we do an error-handling pass, after MQTT gains support for multi-sub and the ability to inform suback callbacks about failures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.