Skip to content

chore(examples): Added raw RSA/AES keyring multithreaded examples #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 8, 2024
Merged

chore(examples): Added raw RSA/AES keyring multithreaded examples #694

merged 27 commits into from
Aug 8, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@RitvikKapila RitvikKapila changed the title Multithreaded tests chore(multi-threaded-examples): Added keyring examples Jun 28, 2024
@RitvikKapila RitvikKapila marked this pull request as ready for review June 28, 2024 00:05
@RitvikKapila RitvikKapila requested a review from a team as a code owner June 28, 2024 00:05
ShubhamChaturvedi7
ShubhamChaturvedi7 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only shared states I see here are the KeyRing, Client, and Plaintext. So as long as this is what we intended to test, the test execution seems random enough to induce any common threading issues.

Base automatically changed from lucmcdon/mpl-v2 to mpl-reviewed August 5, 2024 19:24
@lucasmcdonald3 lucasmcdonald3 changed the title chore(multi-threaded-examples): Added keyring examples chore(multi-threaded-examples): Added raw RSA/AES keyring multithreaded examples Aug 7, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore(multi-threaded-examples): Added raw RSA/AES keyring multithreaded examples chore(examples): Added raw RSA/AES keyring multithreaded examples Aug 7, 2024
ajewellamz
ajewellamz approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit 5e813e7 into mpl-reviewed Aug 8, 2024
227 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the threaded-tests branch August 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamChaturvedi7 ShubhamChaturvedi7 ShubhamChaturvedi7 approved these changes

@ajewellamz ajewellamz ajewellamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasmcdonald3 @ShubhamChaturvedi7 @ajewellamz @RitvikKapila