Skip to content

chore: Change MPL branch, remove PYTHONPATH workarounds #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 5, 2024
Merged

chore: Change MPL branch, remove PYTHONPATH workarounds #683

merged 23 commits into from
Aug 5, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented May 20, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Use the "V2" MPL built on Dafny 4.7
  • Remove Pythonpath hacks
  • Swallow any expected exceptions in test vectors (cleaner test logs)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 changed the title [Draft] New MPL Build chore: MPL without PYTHONPATH May 20, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore: MPL without PYTHONPATH chore: Change MPL branch May 20, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Change MPL branch chore: Change MPL branch, rm PYTHONPATH hacks May 20, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Change MPL branch, rm PYTHONPATH hacks chore: Change MPL branch, remove PYTHONPATH hacks May 20, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Change MPL branch, remove PYTHONPATH hacks chore: Change MPL branch, remove PYTHONPATH workarounds May 22, 2024
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review August 2, 2024 13:54
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner August 2, 2024 13:54
RitvikKapila
RitvikKapila reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just one thing, I think you missed one of the examples: https://github.com/aws/aws-encryption-sdk-python/blob/lucmcdon/mpl-v2/examples/src/default_cryptographic_materials_manager_example.py for removing the sys.path.append commands.

RitvikKapila
RitvikKapila approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit ca7e159 into mpl-reviewed Aug 5, 2024
227 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the lucmcdon/mpl-v2 branch August 5, 2024 19:24
lucasmcdonald3 added a commit that referenced this pull request Aug 6, 2024
@lucasmcdonald3
chore: Change MPL branch, remove PYTHONPATH workarounds (#683)
864d29b
lucasmcdonald3 added a commit that referenced this pull request Aug 6, 2024
@lucasmcdonald3
chore: Change MPL branch, remove PYTHONPATH workarounds (#683)
a8fb0ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitvikKapila RitvikKapila RitvikKapila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmcdonald3 @RitvikKapila