Keyring reorg #198
Merged
Keyring reorg #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistency in namespace names
Because we provide multiple implementations of certain types of things (keyrings, etc), this was triggering pylint due to them all needing to import the same types in order to function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change reorganizes the
keyringnamespace and test structure.The namespace structure changes from:
to:
This was both to match the grammar of the existing namespaces (
key_providers,materials_managers,caches, etc) and to reduce repetition in the namespace path (ex:aws_encryption_sdk.keyring.raw_keyring.RawAesKeyringbecomesaws_encryption_sdk.keyrings.raw.RawAesKeyring).The test reorg is in the spirit of #100, which I actually will have a follow-up PR to implement, to make working with the tests more intuitive.
There are also some minor changes to work around
pylintgetting upset about each keyring module needing to import the same things.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: