Skip to content

Restructure tests to match module heirarchy #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattsb42-aws opened this issue Nov 13, 2018 · 0 comments
Closed

Restructure tests to match module heirarchy #100

mattsb42-aws opened this issue Nov 13, 2018 · 0 comments

Comments

@mattsb42-aws
Copy link
Member

Putting our tests in a structure that matches the source code helps a lot in making the tests discoverable and simple to map to the source that they are testing. We should restructure the tests in this repo to match the source structure, similar to how we structured tests in https://github.com/aws/aws-dynamodb-encryption-python.

@mattsb42-aws mattsb42-aws mentioned this issue Oct 4, 2019
1 task
mattsb42-aws added a commit that referenced this issue Oct 7, 2019
* reorganize keyring tests to match #100 and keyring namespace to simplify names

* change aws_encryption_sdk.keyring to aws_encryption_sdk.keyrings for consistency in namespace names

* autoformat

* disable pylint similarity checks on imports

Because we provide multiple implementations of certain types of things (keyrings, etc),
this was triggering pylint due to them all needing to import the same types in order to function.

* remove aws_encryption_sdk namespace layer in test reorg
mattsb42-aws added a commit that referenced this issue Oct 7, 2019
* reorganize keyring tests to match #100 and keyring namespace to simplify names

* change aws_encryption_sdk.keyring to aws_encryption_sdk.keyrings for consistency in namespace names

* autoformat

* disable pylint similarity checks on imports

Because we provide multiple implementations of certain types of things (keyrings, etc),
this was triggering pylint due to them all needing to import the same types in order to function.

* reorganize functional and integration tests

* define structure for unit tests reorg

* reorganize unit tests

* rename test_values to vectors to avoid it being confused for a test file

* remove aws_encryption_sdk from functional test namespace

* remove aws_encryption_sdk from integration test namespace

* remove aws_encryption_sdk from unit test namespace

* rename test_crypto to vectors to avoid confusion

* autoformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant