Skip to content

Multi keyrings #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Aug 3, 2019
Merged

Multi keyrings #166

merged 64 commits into from
Aug 3, 2019

Conversation

MeghaShetty
Copy link
Contributor

Issue #, if available:

Description of changes:
Dependent on the merging of PRs for base keyring API, keyring materials and raw keyrings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattsb42-aws mattsb42-aws mentioned this pull request Jul 12, 2019
10 tasks
@mattsb42-aws mattsb42-aws changed the base branch from master to keyring July 12, 2019 19:20
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good, with one exception that I missed when I read through before.
Just need to flesh out those tests.

@mattsb42-aws mattsb42-aws mentioned this pull request Aug 1, 2019
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there; just a few more fine points to clean up. :)

mattsb42-aws
mattsb42-aws previously approved these changes Aug 2, 2019
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to merge #165 first, but this looks good to go!

@mattsb42-aws mattsb42-aws merged commit 2e85bfd into aws:keyring Aug 3, 2019
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants