-
Notifications
You must be signed in to change notification settings - Fork 86
Multi keyrings #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi keyrings #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking good, with one exception that I missed when I read through before.
Just need to flesh out those tests.
…urther keyrings are called if data encryption key is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there; just a few more fine points to clean up. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to merge #165 first, but this looks good to go!
Issue #, if available:
Description of changes:
Dependent on the merging of PRs for base keyring API, keyring materials and raw keyrings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.