Skip to content

Raw keyrings #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 123 commits into from
Aug 2, 2019
Merged

Raw keyrings #165

merged 123 commits into from
Aug 2, 2019

Conversation

MeghaShetty
Copy link
Contributor

@MeghaShetty MeghaShetty commented Jun 27, 2019

Issue #, if available:

Description of changes:
Dependent on the merging of the PRs for base API #161 and Keyring materials #163 .

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattsb42-aws mattsb42-aws mentioned this pull request Jul 12, 2019
10 tasks
@mattsb42-aws mattsb42-aws changed the base branch from master to keyring July 12, 2019 19:21
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are looking great!
Almost there. :)

Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just docstrings, some additional test cases, raw RSA MK compatibility, and a bit of cleanup left!

@mattsb42-aws mattsb42-aws merged commit fcc05ba into aws:keyring Aug 2, 2019
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants