Fix handling of partial reads #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add InsistentReaderBytesIO wrapper that will keep reading from the wrapped stream until empty or enough bytes have been collected * update prep_stream_data to make sure that all input data is wrapped in InsistentReaderBytesIO
johnwalker
reviewed
Nov 13, 2018
johnwalker
approved these changes
Nov 13, 2018
karlw00t
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #24
Description of changes:
As noted in #24, the
streaming_clientclasses have not historically correctly handled partial reads. Rather than accepting reads from the source stream that return fewer than the requested number of bytes, they assumed that this meant the source stream was complete. Per PEP 3116, this is incorrect: the stream should not be considered complete until no bytes are returned.In order to simplify logic everywhere else, I ended up just adding a
ProxyObjectwrapper that keeps hitting the wrapped stream on read until it either gets the requested number of bytes or hits the end of the wrapped stream (as indicated by the stream returning nothing).Tightly coupled with this was updating the fix made in #98 to correctly normalize to the bytes to read to
-1rather thanNone. This required a few small tweaks throughoutstreaming_clientto correctly handle this new value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.