Skip to content

streaming_client classes do not properly interpret short reads in source streams #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattsb42-aws opened this issue Nov 1, 2017 · 0 comments
Assignees
Labels

Comments

@mattsb42-aws
Copy link
Member

Problem

Per PEP 3116:

.read(n: int) -> bytes

Read up to n bytes from the object and return them. Fewer than n bytes may be
returned if the operating system call returns fewer than n bytes. If 0 bytes are
returned, this indicates end of file. If the object is in non-blocking mode and no
bytes are available, the call returns None.

The current behavior of the clients in streaming_clients is to interpret reads returning fewer than n bytes as OEF.

Solution

Update clients to properly handle short reads per PEP 3116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant