Skip to content

fix: encrypt/decrypt interface should be the same #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Aug 6, 2019

resolves #182

The encrypt/decrypt browser and node interfaces were slightly different.
Make all the interfaces the same.
The language is chosen to be similar to the Python ESDK

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

resolves aws#182

The encrypt/decrypt browser and node interfaces were slightly different.
Make all the interfaces the same.
The language is chosen to be similar to the Python ESDK
@seebees seebees requested review from mattsb42-aws and a team August 6, 2019 22:43
@seebees seebees merged commit ff78f94 into aws:master Aug 8, 2019
@seebees seebees deleted the encrypt-decrypt-interface-should-be-the-same branch August 8, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring browser and node encrypt/decrypt return values in sync
2 participants