-
Notifications
You must be signed in to change notification settings - Fork 122
chore: Add CI check for formatting #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I vote that we only have the checks in the CI. |
Used jardiff to determine that there is no bytecode change between a jar produced by this branch and master. Used |
Reconfirmed that there is no difference in bytecode using jardiff between this branch and master. |
@seebees You can to run the format check in the same build as the compliance check? |
That is what I was thinking on the JS side, that is what I'm doing. I put the static code analysis all in one place... |
src/test/java/com/amazonaws/encryptionsdk/internal/AwsKmsCmkArnInfoTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add the jardiff
and diff
commands you used for posterity :)
To check byte code difference:
To verify doc changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes: Add check for formatting to CI, and format all code to adhere to google-java-format.
Notes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: